- move static package metadata to setup.cfg
- rename deprecated license_file field to license_files
Remove setuptools arguments:
- test_suite:
Unneeded, as we disable the deprecated setuptools test command
Keep dynamic setuptools arguments:
- version/cmdclass:
For writing static version info via versioneer
- install_requires:
Some dependencies still depend on special environment variables
instead of package "extra" dependency fields
- entry_points:
The `gui_scripts` entry point should only be set when building wheels
for Windows via `--plat-name={win32,win-amd64,cygwin}`
- data_files:
All data files are optional and should not cause the build to fail if
they are missing, eg. when building from sdist
- add streamlink_cli.utils.path.replace_path
- refactor streamlink_cli.utils.formatter.Formatter
- rename filename() to path() and return a pathlib.Path object
- format path parts separately
- replace dot and double-dot path parts if not explicit user input
- replace unsupported chars in path parts (like before)
- refactor streamlink_cli.output.FileOutput
- turn filename into a Path object
- create parent directories before creating the file descriptor
- update streamlink_cli.main accordingly
- update and add new tests
Show an error message when the python_requires classifier of the
package gets ignored, so that users can't accidentally install
an incompatible version of Streamlink with their unsupported
Python version / environment.
Also bump the required version of pip to >=9 in dev-requirements.
Apply the https scheme to all input URLs if the scheme is missing:
- session:
- Session.resolve_url()
- session option `http-proxy` (`--http-proxy` CLI argument)
- plugins.akamaihd: `akamaihd://URL`
- plugins.dash: `dash://URL` or `URL.mpd`
- plugins.hds: `hds://URL` or `URL.f4m`
- plugins.hls: `hls://URL` or `URL.m3u8`
- plugins.http: `httpstream://URL`
Regular http URLs (non-https/TLS) will need to be set explicitly now.
Also
- update/fix test_session
- refactor/fix test_dash
- refactor/fix test_stream
- Ignore branch coverage in `test_can_handle_url_positive`.
This is a parametrized test which is run for each URL independently,
so the first matching matcher will return True in the any() call and
successive matchers won't get checked in the for-loop.
- Add test for checking if all plugin matchers are used.
This is a non-parametrized test which fixes the branch coverage.
- Add missing URL tests for certain plugins.
Update URL schemes to https instead of using the input URL as reference
and set force to False on those plugins which support multiple sites, so
that the https scheme only gets added if it is missing.
Previously, update_scheme only added schemes on scheme-less URLs and
kept target URLs which included a scheme intact.
This is confusing for plugin implementers and it has already been used
incorrectly a lot of times when trying to force the HTTPS protocol on
unencrypted HTTP URLs. Since the method is called update_scheme, it
should do exactly that, in all cases.
However, always updating the target scheme will break those calls of
update_scheme where the scheme was previously only added if needed, eg.
on scheme-less URLs, partial URLs or URL paths.
An example of this are scheme-less input URLs passed to Streamlink's
`Session.resolve_url()`, which has to implicitly set the HTTP scheme.
Always overriding the scheme would turn explicit HTTPS schemes to HTTP,
which can break certain sites/plugins. The various stream-protocol
plugins have the same issue and have to implicitly set a scheme as well.
This change therefore introduces the `force=True` keyword, so that URL
schemes can be set implicitly again in the methods and plugins mentioned
above by setting force to False.
Another effect of forcing the scheme override by default is the pattern
currently used in many plugins, which often update (partial) URLs by
calling `update_scheme(self.url, target)`. Since `self.url` depends on
the user's input and since the input URL's scheme is implicitly set to
HTTP by the Session's URL resolver, target URLs can be downgraded from
HTTPS to HTTP, which is not desired. This is not a problem in cases
where the server will redirect, but it can be a problem where the server
returns an error instead.
These plugins will therefore need to be fixed so that they either set
the URL schemes implicitly or so that they force the according scheme.
Another solution (which will be done eventually) is the change of the
implicit input URL scheme from HTTP to HTTPS in `Session.resolve_url()`
and the various stream-protocol plugins, which will turn all scheme-less
input URLs to HTTPS by default, unless the user explicitly sets an HTTP
URL.
- always update target URL scheme with current URL scheme
- add force=True keyword and do not override scheme if force is False
- set force=False on all implicitly updated URL schemes
- `Session.resolve_url`
- `plugins.{akamaihd,hds,hls,http}`
- parametrize tests, re-order/re-format assertions and add new ones
- move remaining methods from `streamlink.utils` to `streamlink.utils.*`
- streamlink.utils.cache.LRUCache
- streamlink.utils.data.search_dict
- streamlink.utils.module.load_module
- streamlink.utils.rtmp.{escape_librtmp,rtmpparse}
- streamlink.utils.swf.swfdecompress
- fix imports in streamlink, streamlink_cli and tests
- move utils tests into new `tests.utils` package
- split up `test_utils` into individual test modules
- move and rename `test_utils_*`
- move and rename `test_localization`
- fix up some tests
follow-up of 40b604e and de5b27b
- `validate.transform(parse_*, ...)` -> `validate.parse_*(...)`
- fix imports where parse methods are not used in a validation schema
from
```
[stream.hls][error] Failed to create decryptor: ('Unable to decrypt cipher {0}', 'SAMPLE-AES')
```
to
```
[stream.hls][error] Failed to create decryptor: Unable to decrypt cipher SAMPLE-AES
```
bastimeyer