Please register in the repository #1

New issue

Closed

opened 2019-09-14 10:42:27 +00:00 by foosel · 5 comments

foosel commented

2019-09-14 10:42:27 +00:00

As discussed at MRMCD. Pretty please with a cherry on top? 😊

kunsi commented

2019-09-14 13:54:23 +00:00

Owner

it's #NotABug

kunsi commented

2019-09-23 18:24:55 +00:00

Owner

For reference: https://plugins.octoprint.org/help/registering/

Also depends on me adding some kind of update mechanism, so probably ... soon™

For reference: https://plugins.octoprint.org/help/registering/ Also depends on me adding some kind of update mechanism, so probably ... soon™

foosel commented

2019-09-24 10:18:16 +00:00

Author

It doesn't require the implementation of an update hook, but if it is implemented it should be configured correctly. I've had a bunch of plugins that just copy pasted the hook from other plugins, with the fun side effect that they'd trigger an update notification if the other plugin was updated, which prompted the addition of this note to the registration check list.

But if you don't want to implement the update hook (or not yet), you can, it's not mandatory.

It doesn't require the implementation of an update hook, but *if* it is implemented it should be configured correctly. I've had a bunch of plugins that just copy pasted the hook from other plugins, with the fun side effect that they'd trigger an update notification if the *other* plugin was updated, which prompted the addition of this note to the registration check list. But if you don't want to implement the update hook (or not yet), you can, it's not mandatory.

👍 1

kunsi commented

2019-09-24 10:52:40 +00:00

Owner

Oh, that's nice. Then there will be a pull request soon.

👍 1

kunsi commented

2020-09-26 09:37:21 +00:00

Owner

https://github.com/OctoPrint/plugins.octoprint.org/pull/636