Please register in the repository #1

Closed
opened 4 years ago by foosel · 5 comments
foosel commented 4 years ago

As discussed at MRMCD. Pretty please with a cherry on top? 😊

As discussed at MRMCD. Pretty please with a cherry on top? 😊
kunsi commented 4 years ago
Owner

it's #NotABug

it's #NotABug
kunsi commented 4 years ago
Owner

For reference: https://plugins.octoprint.org/help/registering/

Also depends on me adding some kind of update mechanism, so probably ... soon™

For reference: https://plugins.octoprint.org/help/registering/ Also depends on me adding some kind of update mechanism, so probably ... soon™
foosel commented 4 years ago
Poster

It doesn't require the implementation of an update hook, but if it is implemented it should be configured correctly. I've had a bunch of plugins that just copy pasted the hook from other plugins, with the fun side effect that they'd trigger an update notification if the other plugin was updated, which prompted the addition of this note to the registration check list.

But if you don't want to implement the update hook (or not yet), you can, it's not mandatory.

It doesn't require the implementation of an update hook, but *if* it is implemented it should be configured correctly. I've had a bunch of plugins that just copy pasted the hook from other plugins, with the fun side effect that they'd trigger an update notification if the *other* plugin was updated, which prompted the addition of this note to the registration check list. But if you don't want to implement the update hook (or not yet), you can, it's not mandatory.
kunsi commented 4 years ago
Owner

Oh, that's nice. Then there will be a pull request soon.

Oh, that's nice. Then there will be a pull request soon.
kunsi commented 3 years ago
Owner
https://github.com/OctoPrint/plugins.octoprint.org/pull/636
kunsi closed this issue 3 years ago
Sign in to join this conversation.
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kunsi/Octoprint-LCD-HD44780#1
Loading…
There is no content yet.