items/zfs_dataset: add automatic dependency for all files, directories and git_deploy of a dataset

bundles/backup-server/items.py

@@ -14,15 +14,9 @@ for nodename, config in node.metadata.get('backup-server/clients', {}).items():
         'content': pubkey,
         'owner': config['user'],
         'mode': '0400',
-        'needs': {
-            'bundle:zfs',
-        },
     }
 
     directories[f'/srv/backups/{nodename}/backups'] = {
         'owner': config['user'],
         'mode': '0700',
-        'needs': {
-            'bundle:zfs',
-        },
     }

bundles/element-web/metadata.py

@@ -3,9 +3,6 @@ defaults = {
         'datasets': {
             'tank/element-web': {
                 'mountpoint': '/opt/element-web',
-                'needed_by': {
-                    'directory:/opt/element-web',
-                },
             },
         },
     },

bundles/gitea/metadata.py

@@ -50,15 +50,9 @@ defaults = {
             'tank/gitea': {},
             'tank/gitea/home': {
                 'mountpoint': '/home/git',
-                'needed_by': {
-                    'directory:/home/git',
-                },
             },
             'tank/gitea/var': {
                 'mountpoint': '/var/lib/gitea',
-                'needed_by': {
-                    'directory:/var/lib/gitea',
-                },
             },
         },
     },

bundles/nginx/items.py

@@ -139,14 +139,7 @@ for vhost, config in node.metadata.get('nginx/vhosts', {}).items():
     }
 
     if not 'webroot' in config:
-        directories[f'/var/www/{vhost}'] = {}
+        directories[f'/var/www/{vhost}'] = config.get('webroot_config', {})
-
-        if node.has_bundle('zfs'):
-            directories[f'/var/www/{vhost}']['needs'] = {
-                'bundle:zfs',
-            }
-
-        directories[f'/var/www/{vhost}'].update(config.get('webroot_config', {}))
 
     if config.get('ssl', 'letsencrypt') == 'letsencrypt':
         files[f'/etc/nginx/sites/{vhost}']['needs'].add('action:letsencrypt_ensure-some-certificate_{}'.format(config['domain']))

bundles/scansnap/items.py

@@ -8,11 +8,6 @@ directories = {
     },
 }
 
-if node.has_bundle('zfs'):
-    directories['/srv/scansnap']['needs'] = {
-        'bundle:zfs',
-    }
-
 files = {
     '/etc/scanbd/scanbd.conf': {
         'triggers': {

items/zfs_dataset.py

@@ -119,6 +119,14 @@ class ZFSDataset(Item):
                 # XXX Could be optimized by finding the "largest"
                 # parent only.
                 yield item.id
+            elif self.attributes.get('mountpoint'):
+                for item_type in ['directory', 'file', 'git_deploy']:
+                    if (
+                        item.ITEM_TYPE_NAME == item_type and
+                        item.name.startswith('{}:{}'.format(item_type, self.attributes['mountpoint']))
+                    ):
+                        yield item.id
+
 
         if not pool_item_found:
             raise BundleError(_(