bundles/vnstat: rework bundle

bundles/vnstat/files/generate-vnstati

@@ -1,12 +1,8 @@
 #!/bin/bash
 
-TARGET=$1
+set -xeuo pipefail
 
-if [[ -z "$TARGET" ]]
+TARGET="/var/www/vnstat"
-then
-    echo "Usage: $0 <TARGET_DIR>"
-    exit 1
-fi
 
 vnstati --output "$TARGET/summary.png" --summary
 vnstati --output "$TARGET/top10.png" --top 10

bundles/vnstat/files/override.conf

@@ -0,0 +1,6 @@
+[Service]
+ExecStart=
+
+# --nodaemon is default. We also want --alwaysadd to include newly
+# created interfaces, for example when adding vlans to the machine.
+ExecStart=/usr/sbin/vnstatd --alwaysadd --nodaemon

bundles/vnstat/items.py

@@ -1,45 +1,32 @@
-files = {
+files['/etc/systemd/system/vnstat.override.d/bundlewrap.conf'] = {
-    '/etc/systemd/system/vnstati.service': {
+    'source': 'override.conf',
     'triggers': {
         'action:systemd-reload',
+        'svc_systemd:vnstat:restart',
     },
-    },
+}
-    '/etc/systemd/system/vnstati.timer': {
+
-        'triggers': {
+files['/etc/vnstat.conf'] = {
-            'action:systemd-reload',
-        },
-    },
-    '/etc/vnstat.conf': {
     'content_type': 'mako',
     'context': node.metadata['vnstat'],
     'triggers': {
         'svc_systemd:vnstat:restart',
     },
-    },
-    '/usr/local/bin/generate-vnstati': {
-        'mode': '0755',
-    },
 }
 
-if node.metadata.get('vnstat/generate-web-dashboard', False):
+files['/usr/local/bin/generate-vnstati'] = {
-    files['/var/www/vnstat/index.html'] = {
+    'mode': '0755',
+}
+
+files['/var/www/vnstat/index.html'] = {
     'content_type': 'mako',
     'context': node.metadata['vnstat'],
-    }
+}
 
-svc_systemd = {
+svc_systemd['vnstat'] = {
-    'vnstat': {
     'needs': {
-            'pkg_apt:vnstat',
+        'file:/etc/systemd/system/vnstat.override.d/bundlewrap.conf',
         'file:/etc/vnstat.conf',
-        },
+        'pkg_apt:vnstat',
-    },
-    'vnstati.timer': {
-        'needs': {
-            'file:/etc/systemd/system/vnstati.service',
-            'file:/etc/systemd/system/vnstati.timer',
-        },
-        'running': node.metadata.get('vnstat/generate-web-dashboard', False),
-        'enabled': node.metadata.get('vnstat/generate-web-dashboard', False),
     },
 }

bundles/vnstat/metadata.py

@@ -14,6 +14,19 @@ defaults = {
             },
         },
     },
+    'nginx': {
+        'vhosts': {
+            'vnstat': {},
+        },
+    },
+    'systemd-timers': {
+        'timers': {
+            'vnstat-generate-vnstati': {
+                'when': '*:0/10',
+                'command': '/usr/local/bin/generate-vnstati',
+            },
+        },
+    },
     'vnstat': {
         'bandwidth': '1000',
     },

nodes/home/router.py

@@ -161,7 +161,6 @@ nodes['home.router'] = {
             },
         },
         'vnstat': {
-            'generate-web-dashboard': True,
             'interface': 'enp1s0.100',
         },
         'vm': {