bundles/backup-client: do logging

bundles/backup-client/files/logrotate.conf

@@ -0,0 +1,10 @@
+/var/log/backup-client/*.log {
+    compress
+    copytruncate
+    daily
+    dateext
+    missingok
+    notifempty
+    rotate 14
+    sharedscripts
+}

bundles/backup-client/items.py

@@ -47,10 +47,16 @@ files['/usr/local/share/icinga/plugins/check_backup_last_run'] = {
     'mode': '0755',
 }
 
+files['/etc/logrotate.d/backup-client'] = {
+    'source': 'logrotate.conf',
+}
+
 directories['/etc/backup-pre-hooks.d'] = {
     'purge': True,
 }
 
+directories['/var/log/backup-client'] = {}
+
 for hname, hcontent in node.metadata.get('backup-client/pre-hooks', {}).items():
     files[f'/etc/backup-pre-hooks.d/50-{hname}'] = {
         'content': '#!/bin/sh\n\n' + hcontent,

bundles/backup-client/metadata.py

@@ -19,7 +19,7 @@ def cron(metadata):
 
     return {
         'cron': {
-            'backup': '{} 23 * * *    root    /usr/local/bin/generate-backup > /dev/null 2>&1'.format(
+            'backup': '{} 23 * * *    root    /usr/local/bin/generate-backup > /var/log/backup-client/backup.log 2>&1'.format(
                 (node.magic_number % 60),
             ),
         },