qzwi/bundlewrap
2
1
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

ldap_scheme_postfix #3

Merged
stillbeben merged 9 commits from ldap_scheme_postfix into main 2022-01-04 09:35:24 +00:00
Conversation 0 Commits 9 Files changed 5 +76
stillbeben commented 2022-01-03 10:32:26 +00:00
Owner
Copy link
No description provided.
stillbeben added 7 commits 2022-01-03 10:32:27 +00:00 
this scheme extends the schema by adding the externalmail attribute.
it can be adjusted in future
kunsi was assigned by stillbeben 2022-01-03 10:32:32 +00:00
stillbeben requested review from kunsi 2022-01-03 11:26:31 +00:00
kunsi was unassigned by stillbeben 2022-01-03 11:26:35 +00:00
kunsi requested changes 2022-01-03 11:35:04 +00:00
bundles/postfix/items.py
@ -0,0 +1,25 @@
pkg_apt = {
'postfix': {},
kunsi commented 2022-01-03 11:31:36 +00:00
Owner
Copy link

Please install all apt packages via metadata defaults. Bundlewrap can't handle multiple equal item definitions in a repo, so we should stick with only one way of installing packages.

Please install all apt packages via metadata defaults. Bundlewrap can't handle multiple equal item definitions in a repo, so we should stick with only one way of installing packages.
stillbeben marked this conversation as resolved
bundles/postfix/items.py
@ -0,0 +4,4 @@
svc_systemd = {
'postfix': {
'needs': ['pkg_apt:postfix', 'file:/etc/postfix/main.cf'],
kunsi commented 2022-01-03 11:34:18 +00:00
Owner
Copy link

Please use sets here and below.
Please use one line per item in a set/list, and please add a trailing comma to the last item.

I'd recommend we stick to the PEP8 style guide.

Please use sets here and below. Please use one line per item in a set/list, and please add a trailing comma to the last item. I'd recommend we stick to the [PEP8 style guide](https://www.python.org/dev/peps/pep-0008/#when-to-use-trailing-commas).
stillbeben marked this conversation as resolved
stillbeben added 2 commits 2022-01-03 12:47:10 +00:00
stillbeben requested review from kunsi 2022-01-03 13:18:01 +00:00
stillbeben merged commit ee7d8b491b into main 2022-01-04 09:35:24 +00:00
stillbeben deleted branch ldap_scheme_postfix 2022-01-04 09:35:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
kunsi
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: qzwi/bundlewrap#3
No description provided.
Delete branch "ldap_scheme_postfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?