qzwi/bundlewrap
2
1
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

ldap_scheme_postfix #3

Merged
stillbeben merged 9 commits from ldap_scheme_postfix into main 2022-01-04 09:35:24 +00:00
Conversation 0 Commits 9 Files changed 5 +10 -3
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d67869aaf6 - Show all commits

13
bundles/postfix/items.py
View file

@ -1,6 +1,9 @@
svc_systemd = {
'postfix': {
stillbeben marked this conversation as resolved
kunsi commented 2022-01-03 11:31:36 +00:00
Review
Copy link

Please install all apt packages via metadata defaults. Bundlewrap can't handle multiple equal item definitions in a repo, so we should stick with only one way of installing packages.

Please install all apt packages via metadata defaults. Bundlewrap can't handle multiple equal item definitions in a repo, so we should stick with only one way of installing packages.
'needs': ['pkg_apt:postfix', 'file:/etc/postfix/main.cf'],
'needs': [
'pkg_apt:postfix',
'file:/etc/postfix/main.cf',
],
}
stillbeben marked this conversation as resolved
kunsi commented 2022-01-03 11:34:18 +00:00
Review
Copy link

Please use sets here and below.
Please use one line per item in a set/list, and please add a trailing comma to the last item.

I'd recommend we stick to the PEP8 style guide.

Please use sets here and below. Please use one line per item in a set/list, and please add a trailing comma to the last item. I'd recommend we stick to the [PEP8 style guide](https://www.python.org/dev/peps/pep-0008/#when-to-use-trailing-commas).
}
@ -8,7 +11,9 @@ files = {
'/etc/postfix/main.cf': {
'content_type': 'mako',
'needs': ['pkg_apt:postfix'],
'triggers': ['svc_systemd:postfix:restart'],
'triggers': [
'svc_systemd:postfix:restart',
],
},
}
@ -16,6 +21,8 @@ directories = {
'/etc/postfix': {
'owner': 'root',
'mode': '1755',
'needs': ['pkg_apt:postfix'],
'needs': [
'pkg_apt:postfix',
],
},
}