hooks: test zfs metadata consistency

This commit is contained in:
Franzi 2021-12-29 13:23:07 +01:00
parent 0b4f0e142f
commit 390f18a3a4
Signed by: kunsi
GPG key ID: 12E3D2136B818350
3 changed files with 55 additions and 1 deletions

View file

@ -81,6 +81,8 @@ for name, attrs in node.metadata.get('zfs/datasets', {}).items():
if 'mountpoint' not in attrs: if 'mountpoint' not in attrs:
zfs_datasets[name]['canmount'] = 'off' zfs_datasets[name]['canmount'] = 'off'
# https://github.com/bundlewrap/bundlewrap/commit/76647590d684446f146cedb89518458f18dd229e
# zfs_datasets[name]['mountpoint'] = 'none'
else: else:
zfs_datasets[name]['canmount'] = 'on' zfs_datasets[name]['canmount'] = 'on'

View file

@ -1,8 +1,22 @@
from bundlewrap.exceptions import BundleError
from bundlewrap.utils.text import bold, green, yellow
from bundlewrap.utils.ui import io
def test_node(repo, node, **kwargs): def test_node(repo, node, **kwargs):
if not node.has_bundle('backup-client'): if not node.has_bundle('backup-client'):
return return
if node.metadata.get('backups/exclude_from_backups', False): if node.metadata.get('backups/exclude_from_backups', False):
io.stderr('{x} {node} exclude_from_backups=True'.format(
x=yellow("»"),
node=bold(node.name),
))
return return
assert len(node.metadata.get('backups/paths', set())) > 0, f'{node.name} has backups configured, but no backup paths defined!' if not len(node.metadata.get('backups/paths', set())):
raise BundleError(f'{node.name} has backups configured, but no backup paths defined!')
io.stdout('{x} {node} backup metadata conforms to standards'.format(
x=green(""),
node=bold(node.name),
))

View file

@ -0,0 +1,38 @@
from bundlewrap.exceptions import BundleError
from bundlewrap.utils.text import bold, green
from bundlewrap.utils.ui import io
# https://github.com/bundlewrap/bundlewrap/commit/a261304b583b78a16ad44def5508cbc27d5f1c3f
# https://github.com/bundlewrap/bundlewrap/commit/76647590d684446f146cedb89518458f18dd229e
def test_node(repo, node, **kwargs):
if not node.has_bundle('zfs'):
return
zfs_pools = set(node.metadata.get('zfs/pools', {}).keys())
zfs_mountpoints = {}
for name, attrs in node.metadata.get('zfs/datasets', {}).items():
if attrs.get('mountpoint'):
if attrs['mountpoint'] in zfs_mountpoints:
raise BundleError('{n} zfs_dataset:{ds} mountpoint is already taken by {o}'.format(
n=node.name,
ds=name,
o=zfs_mountpoints[attrs['mountpoint']],
))
zfs_mountpoints[attrs['mountpoint']] = name
pool_name = name.split('/', 1)[0]
if pool_name not in zfs_pools:
raise BundleError('{n} zfs_dataset:{ds} wants zfs_pool:{pool}, which wasn\'t found'.format(
n=node.name,
ds=name,
pool=pool_name,
))
io.stdout('{x} {node} zfs metadata is consistent'.format(
x=green(""),
node=bold(node.name),
))