matrix-dimension #43

Closed
sophie wants to merge 15 commits from matrix-dimension into main
Owner

fixes #13

fixes #13
sophie added 5 commits 2021-07-04 18:25:57 +00:00
sophie added 1 commit 2021-07-04 18:28:51 +00:00
All checks were successful
bundlewrap/pipeline/head This commit looks good
49d3e36f9f
bw/htz-cloud.miniserver cleanup extras
kunsi requested changes 2021-07-04 18:34:11 +00:00
@ -0,0 +3,4 @@
After=network.target
[Service]
User=matrix-support
Owner

Please use a user dedicated to this bundle, naming them accordingly

Please use a user dedicated to this bundle, naming them accordingly
Author
Owner

Resolved in b87d3cc975

Resolved in `b87d3cc975`
sophie marked this conversation as resolved
@ -0,0 +1,98 @@
# The web settings for the service (API and UI).
# It is best to have this run on localhost and use a reverse proxy to access Dimension.
web:
port: 8184
Owner

Please change port into the 200xx range and document accordingly in PORT_MAP.md

Please change port into the 200xx range and document accordingly in PORT_MAP.md
Author
Owner

Resolved in 2161698a97

Resolved in `2161698a97`
kunsi marked this conversation as resolved
@ -0,0 +12,4 @@
# The URL that Dimension, go-neb, and other services provisioned by Dimension should
# use to access the homeserver with.
clientServerUrl: "${config['homserver']['clientServeUrl']}"
Owner

Typo? clientServeUrl vs. clientServerUrl

Typo? `clientServeUrl` vs. `clientServerUrl`
Author
Owner

Resolved in 8702e131dc and a65301ee89.

Resolved in `8702e131dc` and `a65301ee89`.
kunsi marked this conversation as resolved
@ -0,0 +27,4 @@
# for tracking custom sticker pack updates. This should be a user configured on the homeserver
# and be dedicated to Dimension (create a user named "dimension" on your homeserver). For
# information on how to acquire an access token, visit https://t2bot.io/docs/access_tokens
accessToken: "${config['homserver']['accessToken']}"
Owner

Typo? homserver vs. homeserver

Typo? `homserver` vs. `homeserver`
Author
Owner

Resolved in 8702e131dc and a65301ee89.

Resolved in `8702e131dc` and `a65301ee89`.
kunsi marked this conversation as resolved
@ -0,0 +89,4 @@
# Settings for controlling how logging works
logging:
file: "${config['data_dir']}/logs/dimension.log"
Owner

I think we can omit that, since systemd takes care of the logging part.

I think we can omit that, since systemd takes care of the logging part.
Author
Owner

Should the console level be verbose instead of into then?

Should the console level be verbose instead of into then?
Owner

I don't think that's needed. We can increase it later, if needed.

I don't think that's needed. We can increase it later, if needed.
Author
Owner

Resolved in 3fd20de161 .

Resolved in `3fd20de161 `.
kunsi marked this conversation as resolved
@ -0,0 +10,4 @@
git_deploy = {
node.metadata['matrix-dimension']['install_dir']: {
'rev': node.metadata.get('matrix-dimension', {}).get('version', 'master'), # doesn't have releases yet
Owner

`node.metadata.get('matrix-dimension/version', 'master')

`node.metadata.get('matrix-dimension/version', 'master')
sophie marked this conversation as resolved
@ -0,0 +1,77 @@
defaults = {
'backups': {
'paths': {
'/opt/matrix-dimension',
Owner

Do we really need to backup this?

Do we really need to backup this?
Author
Owner

npm writes all kinds of install info to this location, I guess so.

npm writes all kinds of install info to this location, I guess so.
Owner

If it's only information we can restore using a bw apply, there should be no need to backup this. But if it's more than that, i'm okay with backing this up.

If it's only information we can restore using a `bw apply`, there should be no need to backup this. But if it's more than that, i'm okay with backing this up.
kunsi marked this conversation as resolved
@ -0,0 +40,4 @@
return {
'nginx': {
'vhosts': {
metadata.get('matrix-dimension/url'): {
Owner

Please use a generic vhost name (like the bundle name), then set domain key inside. Remember to adjust .provides() accordingly.

Please use a generic vhost name (like the bundle name), then set `domain` key inside. Remember to adjust `.provides()` accordingly.
Author
Owner

Resolved in a65301ee89

Resolved in `a65301ee89`
kunsi marked this conversation as resolved
@ -0,0 +69,4 @@
'check_interval': '60m',
},
#'MATRIX-DIMENSION PROCESS': {
# 'command_on_monitored_host': '/usr/lib/nagios/plugins/check_procs -a mautrix-telegram -c 1:',
Owner

Please fix and enable.

Please fix and enable.
Author
Owner

Resolved in 'd74618f9a9'

Resolved in 'd74618f9a9'
kunsi marked this conversation as resolved
sophie added 4 commits 2021-07-04 18:47:43 +00:00
sophie added 1 commit 2021-07-04 18:59:00 +00:00
All checks were successful
bundlewrap/pipeline/head This commit looks good
a65301ee89
bw/matrix-dimension switch to generic vhost name
sophie added 1 commit 2021-07-04 19:06:54 +00:00
All checks were successful
bundlewrap/pipeline/head This commit looks good
3fd20de161
bw/matrix-dimension disable logfile
sophie added 1 commit 2021-07-04 19:11:27 +00:00
Some checks failed
bundlewrap/pipeline/head There was a failure building this commit
07994de66c
bw/matrix-dimension get all the things
sophie requested review from kunsi 2021-07-04 19:15:10 +00:00
sophie added 1 commit 2021-07-04 19:17:17 +00:00
Some checks failed
bundlewrap/pipeline/head There was a failure building this commit
b9135aceca
bw/matrix-dimension remove unneeded metadata
sophie force-pushed matrix-dimension from 76d41a0e47 to d01a7f34a4 2021-07-04 19:34:45 +00:00 Compare
sophie closed this pull request 2021-07-04 19:45:07 +00:00
All checks were successful
bundlewrap/pipeline/head This commit looks good

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: kunsi/bundlewrap#43
No description provided.